Add ListMLE Loss #130
Open
Add ListMLE Loss #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why tests did not run, commenting so that tests run |
abheesht17
requested changes
Aug 11, 2025
keras_rs/api/layers/__init__.py
Outdated
Comment on lines
8
to
16
| from keras_rs.src.layers.embedding.distributed_embedding import DistributedEmbedding as DistributedEmbedding | ||
| from keras_rs.src.layers.embedding.distributed_embedding_config import FeatureConfig as FeatureConfig | ||
| from keras_rs.src.layers.embedding.distributed_embedding_config import TableConfig as TableConfig | ||
| from keras_rs.src.layers.embedding.embed_reduce import EmbedReduce as EmbedReduce | ||
| from keras_rs.src.layers.feature_interaction.dot_interaction import DotInteraction as DotInteraction | ||
| from keras_rs.src.layers.feature_interaction.feature_cross import FeatureCross as FeatureCross | ||
| from keras_rs.src.layers.retrieval.brute_force_retrieval import BruteForceRetrieval as BruteForceRetrieval | ||
| from keras_rs.src.layers.retrieval.hard_negative_mining import HardNegativeMining as HardNegativeMining | ||
| from keras_rs.src.layers.retrieval.remove_accidental_hits import RemoveAccidentalHits as RemoveAccidentalHits |
There was a problem hiding this comment.
Hmmm, these shouldn't be getting re-formatted, in my opinion. Are you on the correct Ruff version? Same for other files
LakshmiKalaKadali
force-pushed
the
listmleloss
branch
from
ef5ee24 to
63388e9
Compare
|
Hi @abheesht17, Done suggested changes. Could you please review the PR. Thank you |
abheesht17
reviewed
Oct 8, 2025
abheesht17
approved these changes
Oct 8, 2025
|
Not sure why we don't have a way to run tests here, need to figure that out before merging |
abheesht17
reviewed
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ListMLELoss code to listwise ranking. This code does not consider Lambda weights.
Here is the gist for verified results with TFRS ListMLELoss